-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[FEATURE REQUEST] Edit space #4687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
0daaf2a
to
6cb74dc
Compare
jesmrec
requested changes
Oct 7, 2025
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListDiffUtil.kt
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListFragment.kt
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListFragment.kt
Show resolved
Hide resolved
.../main/java/com/owncloud/android/presentation/spaces/createspace/CreateSpaceDialogFragment.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/owncloud/android/presentation/spaces/createspace/CreateSpaceDialogFragment.kt
Show resolved
Hide resolved
.../main/java/com/owncloud/android/presentation/spaces/createspace/CreateSpaceDialogFragment.kt
Outdated
Show resolved
Hide resolved
owncloudDomain/src/main/java/com/owncloud/android/domain/spaces/model/OCSpace.kt
Show resolved
Hide resolved
LGTM 👍 |
jesmrec
approved these changes
Oct 7, 2025
Approved on my side, everything perfect! 💯 |
3007077
to
4ca1b8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #4607
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA
Test Plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.7/Spaces%20-%20Edit.md
Reports