Fix OC.joinPaths with empty arguments #17599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When empty arguments are given, the leading or trailing slash was not detected properly.
|
A new inspection was created. |
|
🚀 Test PASSed.🚀 |
Contributor
|
Hopefully, we've covered all the cases now :) 👍 |
Contributor
Author
|
@MorrisJobke mind reviewing this too ? (needed for the webdav PR) |
64 tasks
Contributor
|
👍 |
MorrisJobke
added a commit
that referenced
this pull request
Jul 13, 2015
Fix OC.joinPaths with empty arguments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When empty arguments are given, the leading or trailing slash was not
detected properly.
Please review @icewind1991 @rullzer @oparoz
See the unit test to see what case was broken 😄