Py3 compat, take II

[blizzz]

Rebase of #146, keep fingers crossed, if successful all kudos to @ethifus

[PVince81]

I wonder whether we need to provide two versions for pip now, one for Python 2 and one for Python 3

[PVince81]

Looks good, great work ! 👍

My only concern is about packaging, need to find out how other projects that support both Python 2 and Python 3 do it.

[blizzz]

I have no insights there unfortunately. However, pyhn has a package that is 2 and 3 compatible: https://pypi.python.org/pypi/pyhn/0.3.7, apparently it boils down to specify the supported python versions by a classifier (cf. http://www.diveintopython3.net/packaging.html, here a list https://pypi.python.org/pypi?:action=list_classifiers), i.e. adjusting setup.py. Currently it just says "Python", so it shows up with pip3:

$ pip3 search pyocclient
pyocclient (0.2)  - Python client library for ownCloud

I suggest adding Programming Language :: Python :: 2 and Programming Language :: Python :: 3 with this pull request. Then it should work as usual (i have no idea how to push this to pypi, but I guess you figured it out). Do you want me to add these classifiers?

[PVince81]

@blizzz sounds good, please add the classifiers 😄

[SergioBertolinSG]

Tests running with python3 fails:

 File "owncloud/test/test.py", line 5, in <module>
    from unittest_data_provider import data_provider
ImportError: No module named 'unittest_data_provider'

unittest module is not available in pip3, I have installed unittest2.

[blizzz]

@SergioBertolinSG works for me:

$ pip3 search unittest | grep data
…
unittest-data-provider (1.0.1)     - PHPUnit-like @dataprovider decorator for unittest
…

The Travis tests with 3.5 also succeed.

[SergioBertolinSG]

@blizzz yes that works, thanks.

Tried with both python2 and python3, there is one failure but not related with this changes.

Also, there is a warning .owncloud/test/test.py:472: DeprecationWarning: Please use assertEqual instead.

👍

[blizzz]

@blizzz sounds good, please add the classifiers 😄

done 🐍

[PVince81]

Weird, now the unit tests have failures

[PVince81]

you missed the commas

[blizzz]

😱

[blizzz]

Now, still failing. This is strange, isn't it.

[PVince81]

Yeah, strange. Maybe Travis updated their Python version or changed the warning flags ?

The error seems about a file that did not get closed properly. Maybe we're missing a fclose statement somewhere ?

[blizzz]

Yeah, strange. Maybe Travis updated their Python version or changed the warning flags ?

The last ones passing where also 2.7.10 and 3.5.0. Maybe some module got an update.

The error seems about a file that did not get closed properly. Maybe we're missing a fclose statement somewhere ?

Maybe on 3. On 2.7 it's just InvalidHeader: Header value 1 must be of type str or bytes, not <type 'int'> deep in the requests module.

[SergioBertolinSG]

Yes the error happens after the upgrade to requests-2.11.0, I tested this with requests-2.10.0 and it worked fine.

[blizzz]

Woohoo 👍 @SergioBertolinSG

[PVince81]

@blizzz wanna add this thing to the changelog with credits yourself ? Else I'll do it later at release time.

[blizzz]

the credits should go to @ethifus really

[PVince81]

Ok, added 7af7a5a

[blizzz]

thx 🎩