-
Notifications
You must be signed in to change notification settings - Fork 119
Add dav endpoint version support #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @soalhn, @individual-it and @Gomez to be potential reviewers. |
|
Looks like it's not possible to make it skip the whole class that tests DAV v1. Skipping in setUp only seems to skip the first test. Then the other tests likely aren't running setUp again like in PHP, so the check is not done. I could use a skip decorator but it needs to be applied on ALL tests. Need to think of a better way... |
|
Now added a custom decorator to skip the test class in case DAV v1.0 is detected. |
|
All tests passed now, will cleanup the history |
If the endpoint version is specified in the constructor, use that. Else read it from the capabilities call.
|
@SergioBertolinSG please review |
|
Locally i am seeing a couple of failures: This is running against master. (10.0.0beta). |
|
@SergioBertolinSG is the OC env you're testing against clean ? |
|
Maybe not, I can try with a different "clean" one. |
|
OK, with a clean server it has worked all fine. |
If the endpoint version is specified in the constructor, use that.
Else read it from the capabilities call.