[tests-only] [full-ci] test: [OCISDEV-417] add a11y playwright tests #13268
Conversation
LukasHirt
force-pushed
the
test/a11y-tests
branch
4 times, most recently
from
e5f3541 to
1aae2c5
Compare
Setup new Playwright a11y tests and add a11y reporter. Accessibility checks are added into existing E2E tests. Docs are added to explain the new accessibility tests.
LukasHirt
force-pushed
the
test/a11y-tests
branch
from
1aae2c5 to
252e568
Compare
|
|
@mzner please review the vue changes. |
| v-bind="componentProps" | ||
| :class="[action.class, 'action-menu-item', 'oc-py-s', 'oc-px-m', 'oc-width-1-1']" | ||
| :aria-label="componentProps.disabled ? action.disabledTooltip?.(actionOptions) : ''" | ||
| :aria-label="componentProps.disabled ? action.disabledTooltip?.(actionOptions) : null" |
There was a problem hiding this comment.
Should we be using a label instead of null?
There was a problem hiding this comment.
We need the label to be gone if the button is not disabled and with '' it is unfortunately persisted on the element (even though with no value). Using null makes sure that the label is gone.
| <template> | ||
| <li v-oc-tooltip="componentProps.disabled ? action.disabledTooltip?.(actionOptions) : ''"> | ||
| <oc-button | ||
| v-oc-tooltip="showTooltip || action.hideLabel ? action.label(actionOptions) : ''" |
There was a problem hiding this comment.
Is there a difference between this and :title?
There was a problem hiding this comment.
tooltip is not available to screen readers.
| this.outputFile = options.outputFile || 'a11y-report.json' | ||
| } | ||
|
|
||
| onBegin(_config: FullConfig, _suite: Suite): void { |
There was a problem hiding this comment.
Not that important, but what do you think about using onStart instead of onBegin?
There was a problem hiding this comment.
We cannot use arbitrary name here because these methods are overwriting the ones from the reporter class.
There was a problem hiding this comment.
Description
Setup new Playwright a11y tests and add a11y reporter. Accessibility checks are added into existing E2E tests. Docs are added to explain the new accessibility tests.
Motivation and Context
Migrating tests from cucumber to playwright.
How Has This Been Tested?
Types of changes