-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instance Metrics using OxQL #2654
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Once you have something basically working (you might already, I didn’t check) it might be worth looking at getting better mock data to make iteration and testing easier. One way to start would be to take a real response for a decent sized time range and hard code it as a mock response, filtered by the time range extracted from the OxQL query with regexes. It’ll be janky but the goal is to be just complex enough to support testing the UI. |
That's probably better, to get something more accurate. I have a silly alternative that could work. By modifying the |
It's coming along; will push latest shortly. I had been originally trying to map the existing charts, but chatted with @bnaecker on Friday, and he noted that showing the data as it comes through from OxQL will be a bit more useful to people. Regarding the existing (top) and new (bottom) charts …
Two instances to check out from dogfood to see read data:
Alan noted that Crucible is having some issues writing write data, so the writes charts aren't useful right now. |
Looks fantastic. Glad the data is more useful! |
…e succcessfully loaded in
Making note of a few polish things would be nice to get in:
|
* OxQL metrics more actions * take CopyCodeModal refactor further, fix motion import * move oxql schema docs thing into links file --------- Co-authored-by: David Crespo <[email protected]>
* Dynamic Y axis width * Remove spacing and make tick size/margin explicit * Need spacing on old cards
Still very much in flux; creating a draft PR for easier comparing/contrasting/discussing.