[ddm-admin-client] Remove sneaky tokio::spawn()s #7507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to our
ddm-admin-clientwrapper library:advertise_prefixis nowadvertise_prefixes, and is a straight pass-through to the underlying progenitor client (i.e., it no longertokio::spawn()s an infinite retry loop). I inlined the retry loop at all the call sites. This is messy in sled-agent, and I stuck comments on them about cleaning up. It also makes it super obvious that one of them is not correct (as we noted in [sled agent] Zone initialization causes maghemite advertisement, but nothing stops this on zone teardown #7377).enable_statsgot the same treatment (no moretokio::spawn; inline the retry loop at its one callsite).advertise_tunnel_endpoint()(it had no callers).This gets rid of all the hidden
tokio::spawn()s, which fixes #7378.I think the chances of this breaking something are pretty small, but since it touches installinator, I'll run through a mupdate on a racklette before merging.