[16/n] send resolver status up via inventory #8300
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1 [skip ci]
|
Likely going to re-do this based on discussion today. |
sunshowers
changed the title
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
sunshowers
changed the title
Created using spr 1.3.6-beta.1
sunshowers
changed the base branch from
sunshowers/spr/main.13n-send-resolver-status-up-via-inventory
to
main
Created using spr 1.3.6-beta.1
| pub is_valid: bool, | ||
|
|
||
| /// A message describing the status. If `is_valid` is false, then this | ||
| /// message describes the reason for the invalid status. |
There was a problem hiding this comment.
What will the message describe if is_valid is true?
There was a problem hiding this comment.
In that case it's a textual representation of inventory that looks like:
5 artifacts in manifest generated by installinator (mupdate ID: 00000000-0000-0000-0000-000000000000): 5 valid, 0 mismatched, 0 errors:
- zone1.tar.gz: valid (5 bytes, a34f924efa72cd0139ea5dc268f5d2736a9ebc858552b8f3c8cb2bed1992c31d)
- zone2.tar.gz: valid (5 bytes, 930c5a9adbeb8410817a1dff05d7cbffe4ada2ddbeaacecadd7cbcb35a233231)
- zone3.tar.gz: valid (5 bytes, 0f40fdb255100d0239a7e0944c8b9fdb9ba4795ad72988eaeeb00e9346236e08)
- zone4.tar.gz: valid (5 bytes, 64d6e4a84209b4b02f4da36d24eae12b0d1ec9e414d1c3bd12a261a245148324)
- zone5.tar.gz: valid (5 bytes, 112b21db93f16057fa957a58b711bff40ec395c9147d4084a88c9085c6507bf7)
There was a problem hiding this comment.
Expanded the comment here and below.
andrewjstone
left a comment
andrewjstone
left a comment
There was a problem hiding this comment.
Looks good. Someday we will fix the redundant M.2 issues for all consumers.
|
|
||
| #[derive(Clone, Debug, PartialEq, Eq, Deserialize, JsonSchema, Serialize)] | ||
| pub struct ZoneArtifactInventory { | ||
| /// The filename. |
There was a problem hiding this comment.
Were these comments written by an LLM? They don't seem very helpful.
I do, on the other hand, think that header docs for each type could be useful. For example, what is a ZoneManifest or MupdateOverride.
There was a problem hiding this comment.
Actually no, I handwrote them 😭 -- I just like all pub fields being documented. I'll try adding some more information like "always ends with .tar.gz".
There was a problem hiding this comment.
Sorry, that was quite rude and untactful of me.
There was a problem hiding this comment.
Expanded the doc comments significantly, think it's much better now -- thanks!
There was a problem hiding this comment.
Expanded the doc comments significantly, think it's much better now -- thanks!
Looks great!
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/13n-send-resolver-status-up-via-inventory
branch
Was working in this area, thought it would be a nice cleanup. Depends on: * #8300
Create:
representativeexampleDepends on: