feat: add CRF (Constant Rate Factor) support for quality-based encoding#1
Merged
maharajamihir merged 2 commits intomacos-supportfrom Mar 30, 2026
Merged
feat: add CRF (Constant Rate Factor) support for quality-based encoding#1maharajamihir merged 2 commits intomacos-supportfrom
maharajamihir merged 2 commits intomacos-supportfrom
Conversation
Adds optional CRF rate control to SimpleOutputBuilder. When set, VideoToolbox (macOS) and x264 encoders use CRF instead of CBR for better quality-per-bit, especially for text-heavy screen recordings. Other encoders (NVENC/AMF/QSV) gracefully fall back to CBR. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
VideoToolbox uses "quality" (0-100 scale, higher=better) not "crf". x264 uses "crf" (0-51 scale, lower=better). Map the unified 0-100 quality input to each encoder's native scale. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional CRF rate control to SimpleOutputBuilder. When set, VideoToolbox (macOS) and x264 encoders use CRF instead of CBR for better quality-per-bit, especially for text-heavy screen recordings. Other encoders (NVENC/AMF/QSV) gracefully fall back to CBR.