Bump react-dom and @types/react-dom - #26
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together. Updates `react-dom` from 18.3.1 to 19.2.6 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.6/packages/react-dom) Updates `@types/react-dom` from 18.3.0 to 19.2.3 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: react-dom dependency-version: 19.2.6 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/react-dom" dependency-version: 19.2.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughRoot ChangesReact DOM Upgrade
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 28: Package.json currently pins mismatched React majors: the "react"
dependency is "18.3.1" while "react-dom" is "19.2.6", which causes
peer-dependency warnings and runtime instability; fix by aligning majors —
either upgrade "react" to a 19.x release or downgrade "react-dom" to an 18.x
release so both "react" and "react-dom" share the same major version, and update
any workspace/package-lock entries accordingly to ensure consistent installs.
In `@web/package.json`:
- Around line 14-19: The package.json mixes React 18 and ReactDOM 19; update the
dependency set so all React-related packages use the same major (choose either
React 19 or keep React 18) by making react, react-dom, `@types/react` and
`@types/react-dom` the same major version; ensure the choice matches how
apps/web/src/main.tsx imports react-dom/client and adjust the four package
entries (react, react-dom, `@types/react`, `@types/react-dom`) to the chosen major
version so types and runtime are aligned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 513d706d-3cbe-4b10-a9d5-88dd9ef8f631
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
package.jsonweb/package.json
| "dependencies": { | ||
| "react": "18.3.1", | ||
| "react-dom": "18.3.1" | ||
| "react-dom": "19.2.6" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
python - <<'PY'
import json, pathlib, urllib.request, urllib.parse
root = json.loads(pathlib.Path("package.json").read_text())
print("root react :", root.get("dependencies", {}).get("react"))
print("root react-dom :", root.get("dependencies", {}).get("react-dom"))
def fetch_peers(pkg, ver):
url = f"https://registry.npmjs.org/{urllib.parse.quote(pkg, safe='')}/{ver}"
with urllib.request.urlopen(url) as r:
data = json.load(r)
print(f"{pkg}@{ver} peerDependencies:", data.get("peerDependencies"))
fetch_peers("react-dom", "19.2.6")
PYRepository: p-to-q/aleph
Length of output: 2746
Align react and react-dom major versions
package.json pins "react": "18.3.1" (line 27) while "react-dom" is set to "19.2.6" (line 28), creating a React major-version skew that commonly leads to peer-dependency warnings and install/runtime instability across workspaces.
"react": "18.3.1",
"react-dom": "19.2.6"Fix by either bumping "react" to 19.x consistently across the workspace or downgrading "react-dom" to an 18.x version that matches.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 28, Package.json currently pins mismatched React
majors: the "react" dependency is "18.3.1" while "react-dom" is "19.2.6", which
causes peer-dependency warnings and runtime instability; fix by aligning majors
— either upgrade "react" to a 19.x release or downgrade "react-dom" to an 18.x
release so both "react" and "react-dom" share the same major version, and update
any workspace/package-lock entries accordingly to ensure consistent installs.
Comment on lines
+14
to
+19
| "react-dom": "19.2.6" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/node": "20.11.17", | ||
| "@types/react": "18.3.3", | ||
| "@types/react-dom": "18.3.0", | ||
| "@types/react-dom": "19.2.3", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== web/package.json =="
cat -n web/package.json | sed -n '1,120p'
echo
echo "== Search for react-dom/client usage =="
rg -n "react-dom/client" -S .
echo
echo "== apps/web/src/main.tsx =="
if [ -f apps/web/src/main.tsx ]; then
cat -n apps/web/src/main.tsx | sed -n '1,120p'
else
echo "File apps/web/src/main.tsx not found"
fiRepository: p-to-q/aleph
Length of output: 1198
Critical: Align React/ReactDOM runtime + type versions in web/package.json
web/package.json mixes React 18 with ReactDOM 19 (react@18.3.1 + react-dom@19.2.6, lines 13–14) and the corresponding DefinitelyTyped packages (@types/react@18.3.3 + @types/react-dom@19.2.3, lines 18–19), while apps/web/src/main.tsx uses react-dom/client. Update the dependency set to a consistent React major version (either fully React 19 or keep all React/DOM packages on 18.x) in this PR.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/package.json` around lines 14 - 19, The package.json mixes React 18 and
ReactDOM 19; update the dependency set so all React-related packages use the
same major (choose either React 19 or keep React 18) by making react, react-dom,
`@types/react` and `@types/react-dom` the same major version; ensure the choice
matches how apps/web/src/main.tsx imports react-dom/client and adjust the four
package entries (react, react-dom, `@types/react`, `@types/react-dom`) to the chosen
major version so types and runtime are aligned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates
react-domfrom 18.3.1 to 19.2.6Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
eaf3e95Version 19.2.623f4f9f19.2.590ab3f8Version 19.2.4612e371Version 19.2.3b910fc1Version 19.2.2053df4eVersion 19.2.18618113Bump scheduler version (#34671)1bd1f01Ship partial-prerendering APIs to Canary (#34633)2f0649a[Fizz] Removenonceoption from resume-and-prerender APIs (#34664)5667a41Bump next prerelease version numbers (#34639)Updates
@types/react-domfrom 18.3.0 to 19.2.3Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)