Restructure CTL1 input handling #129
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cerminar
force-pushed
the
142X_newmodels_v1
branch
2 times, most recently
from
6208d26 to
0eb5916
Compare
cerminar
force-pushed
the
142X_newmodels_v1
branch
from
f950009 to
684189a
Compare
cerminar
force-pushed
the
142X_newmodels_v1
branch
from
05e2706 to
f606038
Compare
cerminar
force-pushed
the
142X_newmodels_v1
branch
2 times, most recently
from
e435c4a to
297e9fe
Compare
- only working mechanics. HGCal content still empty - PFCandidates now own a pointer to L1Candidates - PFProdure can write out PFClusters with decoded information - started moving functionality of PFCLuster converters in PF producer
cerminar
force-pushed
the
142X_newmodels_v1
branch
3 times, most recently
from
cf7c295 to
3e9b810
Compare
cerminar
force-pushed
the
142X_newmodels_v1
branch
3 times, most recently
from
a17e44d to
02c946c
Compare
…s introducing custom packing/unpacking for barrel/endcap
…o across the whole detector plus some other fixes.
cerminar
force-pushed
the
142X_newmodels_v1
branch
from
a2badbb to
e7cab22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
In preparation of the integration of the GCT emulated clusters, this PR rewrites the handling of the calorimeter inputs by the CTL1 emulator.
In particular:
PFClustermoving all needed manipulations (calibs, ID models etc etc) to the emulatorPFClustercollections directly from the CTL1 emulator AFTER the decoding (this will be useful for training models using exactly the decoded information)PFClusterdata-format to store digitized objects in packed format. This allows retrieving quantized quantities in the ntuplization stepsPR validation:
Ongoing. e/g functionality is preserved:
Plots at: https://cerminar.web.cern.ch/cerminar/plots/142X_newmodels_v4
PF functionality needs to be tested.