Skip to content

feat(theme-handler): implement browser://theme protocol handler #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat(theme-handler): implement browser://theme protocol handler #43

wants to merge 18 commits into from

Conversation

akhileshthite
Copy link
Member

Closes: #37

Related Issues: AgregoreWeb/agregore-browser#289

@akhileshthite akhileshthite requested a review from RangerMauve May 4, 2025 23:30
@akhileshthite akhileshthite self-assigned this May 4, 2025
@akhileshthite akhileshthite added documentation Improvements or additions to documentation enhancement New feature or request protocol New protocol to support :// labels May 4, 2025
@akhileshthite akhileshthite mentioned this pull request May 5, 2025
Closed
@RangerMauve
Copy link
Collaborator

For the vars maybe we can ditch base16 for something more simple?

AgregoreWeb/agregore-browser#289

e.g.

--browser-theme-font-family
--browser-theme-background
--browser-theme-text-color
--browser-theme-primary-highlight
--browser-theme-secondary-highlight

Maybe these would be the only things in the vars and the rest would be in base.css since it's browser specific?

@akhileshthite
Copy link
Member Author

For the vars maybe we can ditch base16 for something more simple?

AgregoreWeb/agregore-browser#289

e.g.

--browser-theme-font-family
--browser-theme-background
--browser-theme-text-color
--browser-theme-primary-highlight
--browser-theme-secondary-highlight

Maybe these would be the only things in the vars and the rest would be in base.css since it's browser specific?

Yep, correct!
Will make these changes.

@akhileshthite akhileshthite requested a review from RangerMauve May 12, 2025 01:53
@akhileshthite
Copy link
Member Author

I'll stick with Base16 for Peersky's vars.css with standardized --browser-theme- variables and Peersky-specific variables for UI components like buttons and navigation.

https://github.com/p2plabsxyz/peersky-browser/blob/theme-protocol/src/pages/theme/vars.css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RangerMauve RangerMauve Awaiting requested review from RangerMauve

Assignees

@RangerMauve RangerMauve

@akhileshthite akhileshthite

Labels
documentation Improvements or additions to documentation enhancement New feature or request protocol New protocol to support ://
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue Title: Standardize on "theme URLs" cross browser
2 participants
@akhileshthite @RangerMauve