PUBLIC: [P4-Constraints] Remove usages of DebugString. #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-dilorenzo
force-pushed
the
cl/599891641
branch
6 times, most recently
from
5493cb0 to
494cca8
Compare
jonathan-dilorenzo
previously approved these changes
Jan 19, 2024
jonathan-dilorenzo
force-pushed
the
cl/599891641
branch
3 times, most recently
from
a77c239 to
2e7e128
Compare
LSC: C++ DebugString to AbslStringify
In this LSC, we replace calls to C++ Protobuf DebugString APIs with implicit AbslStringify conversions or absl::StrCat. This makes debug information incompatible with TextFormat parsers (go/explicit-debug-string), redacts Datapol-annotated SPII values (go/redact-debug-string), and introduces per-process-randomized syntax.
Background:
DebugString callers should not rely on DebugString output (go/no-more-debugstring). proto2::Message DebugString APIs will be deprecated by Protobuf's AbslStringify in order to support SPII redaction. We are incrementally migrating DebugString calls to the new API whenever we are confident it is safe to do so. If this CL causes breakage, please roll back and notify us (orrery-debug-string@).
LSC proposal: go/cpp-debug-string-to-absl-stringify
ISE LSC checklist: go/cpp-debugstring-to-stringify-checklist
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:598320964:BASE:598306044:1705214817104:33c3a758
PiperOrigin-RevId: 599891641
jonathan-dilorenzo
force-pushed
the
cl/599891641
branch
from
2e7e128 to
7a61f2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PUBLIC: [P4-Constraints] Remove usages of DebugString.
LSC: C++ DebugString to AbslStringify
In this LSC, we replace calls to C++ Protobuf DebugString APIs with implicit AbslStringify conversions or absl::StrCat. This makes debug information incompatible with TextFormat parsers (go/explicit-debug-string), redacts Datapol-annotated SPII values (go/redact-debug-string), and introduces per-process-randomized syntax.
Background:
DebugString callers should not rely on DebugString output (go/no-more-debugstring). proto2::Message DebugString APIs will be deprecated by Protobuf's AbslStringify in order to support SPII redaction. We are incrementally migrating DebugString calls to the new API whenever we are confident it is safe to do so. If this CL causes breakage, please roll back and notify us (orrery-debug-string@).
LSC proposal: go/cpp-debug-string-to-absl-stringify
ISE LSC checklist: go/cpp-debugstring-to-stringify-checklist
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:598320964:BASE:598306044:1705214817104:33c3a758