Open
Conversation
…ody when templates are used
|
Hi @whitepaperclip, thanks for your work on this. I'd love to see it merged. I did notice that your PR contains a bunch of unrelated formatting changes, presumably due to an editor integration with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the work on this library!
Instead of requiring
TemplateIdto be passed in, this allowsTemplateAliasto be used instead, via:email |> template({:alias, "my-template-alias"})This PR also includes another important fix: when a template is passed into the request, if the
HtmlBodyorTextBodykeys are present (even if the values arenull), Postmark responds with:{"ErrorCode":402,"Message":"Received invalid JSON input."}🙄I've removed the inclusion of these keys in the request if a template is used.