Upgrade to latest libraries and cleanup warnings#43
Open
tispratik wants to merge 6 commits intopablo-co:masterfrom
Open
Upgrade to latest libraries and cleanup warnings#43tispratik wants to merge 6 commits intopablo-co:masterfrom
tispratik wants to merge 6 commits intopablo-co:masterfrom
Conversation
Resolve BadMapError in FakePostmark.get_free_port/0 by updating ranch_tcp.listen/1
call to use map syntax (%{port: 0}) instead of keyword list (port: 0). This fixes
test failures caused by ranch expecting map arguments.
Update deprecated Plug.Adapters.Cowboy functions to use modern Plug.Cowboy API:
- Replace Plug.Adapters.Cowboy.http/3 with Plug.Cowboy.http/3
- Replace Plug.Adapters.Cowboy.shutdown/1 with Plug.Cowboy.shutdown/1
- Remove unused alias to eliminate compiler warnings
Also includes automatic code formatting improvements from mix format.
Fixes test: "can read the api key from an ENV var" and eliminates all
deprecation warnings in test output.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Major dependency updates: - Bamboo: ">= 2.0.0" → ">= 2.5.0" for latest features and compatibility - Hackney: ">= 1.6.5" → ">= 1.25.0" with override flag for HTTP client stability - Poison: ">= 1.5.0" → ">= 6.0.0" for modern JSON handling - Plug: "~> 1.0" → "~> 1.18.1" for latest web interface compatibility - Plug Cowboy: "~> 1.0" → "~> 2.7.4" for HTTP/2 support and performance improvements - Add Credo: "~> 1.7.12" for code quality and style checking Configuration modernization: - Replace deprecated `use Mix.Config` with `import Config` in config/config.exs - Add .tool-versions file specifying Erlang 27.2 and Elixir 1.18.3-otp-27 Code quality improvements in PostmarkAdapter: - Add comprehensive @doc annotations for public functions - Improve code formatting and readability with consistent indentation - Convert deprecated atom key syntax (:"Key") to modern atom syntax (:Key) - Fix variable shadowing issues (email -> email_address) - Enhance function parameter organization and readability - Update attachment handling with better formatting - Improve error message formatting with proper inspect() calls PostmarkHelper enhancements: - Better function clause formatting for template/4 function - Consistent code style improvements These changes maintain backward compatibility while preparing the codebase for modern Elixir ecosystem standards and improved maintainability. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Lock file updates following dependency version upgrades in mix.exs: - Updated all transitive dependencies to compatible versions - Resolved version conflicts with override flags where needed - Ensures reproducible builds with locked dependency versions This completes the modernization to Elixir 1.18/OTP 27 compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The override: true flag is not needed for hackney because: - Bamboo requires hackney >= 1.15.2 - We specify hackney >= 1.25.0 - Our version requirement (1.25.0) satisfies bamboo's requirement (>= 1.15.2) Override flags should only be used when forcing conflicting dependency versions. In this case, the versions are compatible and resolve naturally. Verified that dependency resolution and tests still pass without the override. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also integrated message stream in API
Support template alias