Padronização do header X-PagarMe-User-Agent V4 #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfwill-dev
force-pushed
the
fix/refactor-useragent-header-v4
branch
2 times, most recently
from
abfe642 to
01125c1
Compare
sfwill-dev
force-pushed
the
fix/refactor-useragent-header-v4
branch
from
01125c1 to
4a1f62e
Compare
sfwill-dev
changed the title
murilohns
approved these changes
Sep 9, 2020
michaelfidelis
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Com o intuito de criar a possibilidade de monitorar o uso de nossos SDKs, esse PR tem o objetivo de padronizar o header X-PagarMe-User-Agent, enviando a versão do sdk em uso.
Diferente da v3, pelo que vi a v4 ainda não tinha a versão do SDK armazenada em uma constant. Adicionei isso também nesse PR.
Issue relacionada: https://github.com/pagarme/Support/issues/181