Padronização do header X-PagarMe-User-Agent V3 #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfwill-dev
force-pushed
the
fix/refactor-useragent-header-v3
branch
from
2460a24 to
18547da
Compare
sfwill-dev
force-pushed
the
fix/refactor-useragent-header-v3
branch
from
18547da to
577dc1d
Compare
sfwill-dev
changed the title
sfwill-dev
force-pushed
the
fix/refactor-useragent-header-v3
branch
4 times, most recently
from
fc01304 to
3235ba8
Compare
sfwill-dev
force-pushed
the
fix/refactor-useragent-header-v3
branch
from
3235ba8 to
bbada41
Compare
murilohns
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Com o intuito de criar a possibilidade de monitorar o uso de nossos SDKs, esse PR tem o objetivo de padronizar o header X-PagarMe-User-Agent, enviando a versão do PHP em uso, além da versão do SDK.
Obs.: Foi necessário ajustar alguns testes que nem tem relação com esse PR, devido à config da company de teste não aceitar parcelamento na bandeira Diners e também aos Payables agora serem async com o Atlas. Também estava ocorrendo incompatibilidade com o phpunit 4, guzzlehttp e a versão 7.2 do PHP:
Fatal error: Declaration of Mock_Client_8cee1f51::sendAsync(Psr\Http\Message\RequestInterface $request, array $options = Array) must be compatible with GuzzleHttp\Client::sendAsync(Psr\Http\Message\RequestInterface $request, array $options = Array): GuzzleHttp\Promise\PromiseInterface in /root/repo/vendor/phpunit/phpunit-mock-objects/src/Framework/MockObject/Generator.php(290) : eval()'d code on line 1Porém se atualizarmos o phpunit não será mais possível testar nas versões 5 do PHP. Fixei a versão do guzzlehttp no composer.json. Lembrando que essa é a V3 do nosso SDK, ainda em uso, porém a mais atual é a V4.
Issue relacionada: https://github.com/pagarme/Support/issues/181