You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey Andrew 👋
Thanks for the PR. I'm wondering if the right thing to do is for the buildpack to still detect? (but accommodate submodules as well - like git rev-parse HEAD:path-to-sub-module instead of git rev-parse HEAD for example).
@paketo-buildpacks/utilities-maintainers I feel like the use case of extracting git metadata is valid for submodules just like root level git repos. WDYT?
@menehune23 And would a project.toml exclude give your issue some temporary relief until we figure out the right way to do it
Hey @arjun024, thanks for getting back about this! I do think that project.toml should help alleviate this for now, since the exclude field is respected by kpack (which is ultimately what is running our build).
Feel free to close this if y'all determine this isn't the right approach. Glad it's on the radar now :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fails detection when
.gitis a file and not a folder.Use Cases
Closes #275
Checklist