Skip to content

fixed bug causing white screen - #186

Merged
palchhinparihar merged 2 commits into
palchhinparihar:mainfrom
vishruthmd:fix/clear-text
Oct 29, 2025
Merged

fixed bug causing white screen#186
palchhinparihar merged 2 commits into
palchhinparihar:mainfrom
vishruthmd:fix/clear-text

Conversation

@vishruthmd

Copy link
Copy Markdown
Contributor

📝 Description

This PR fixes the bug causing white screen when "Clear text" button was clicked

Fixes #179

🔍 Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧹 Code refactor (cleanup or optimization)
  • 🧪 Tests added/updated
  • 📝 Documentation update

🧪 How Has This Been Tested?

  1. now, once the text is typed and we click on "Clear text", a popup/dialog box leading to confirmation for clearing text pops up.

Steps:

  1. Run the application
  2. Write some text
  3. Click on "Clear Text"
  4. a Dialog box will popup
  5. click on "Clear"
  6. The text will safely get cleared
  7. if you click on "Cancel" the dialog box is safely exited
  8. now, you will not encounter the white screen at an point of this process.

📸 Screenshots / Demo (if applicable)

image popup appears when "Clear text" is clicked. image the textbox gets cleared when the "Clear" button is clicked in the dialog box. ---

🧠 Checklist

  • My code follows the project's coding style and conventions
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • I have updated related documentation (if applicable)
  • My changes generate no new warnings or errors
  • I have linked related issue numbers (if any)
  • All tests pass successfully

💬 Additional Notes

this now also works when the trash icon is clicked to clear the screen

@netlify

netlify Bot commented Oct 29, 2025

Copy link
Copy Markdown

Deploy Preview for wordwizard-texteditor ready!

Name Link
🔨 Latest commit 6029656
🔍 Latest deploy log https://app.netlify.com/projects/wordwizard-texteditor/deploys/690229c97c7bc40008acb493
😎 Deploy Preview https://deploy-preview-186--wordwizard-texteditor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vishruthmd

Copy link
Copy Markdown
Contributor Author

@palchhinparihar , i have made the necessary changes! please do check :)

@palchhinparihar

Copy link
Copy Markdown
Owner

hi, @vishruthmd just add cursor-pointer on that dialog buttons

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes code formatting across the TextForm and DialogBox components by converting inconsistent indentation to a uniform 4-space indentation pattern. Additionally, it includes two bug fixes and removes "peer": true flags from package-lock.json.

  • Reformats TextForm.jsx and DialogBox.jsx with consistent 4-space indentation
  • Adds setActiveOperation prop to DialogBox to properly reset UI state
  • Fixes grammar check button logic in the "generate-lorem" branch
  • Cleans up package-lock.json by removing unnecessary peer flags

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/components/TextForm.jsx Standardized indentation to 4 spaces, fixed grammar check button display logic in generate-lorem branch, and passed setActiveOperation to DialogBox
src/components/DialogBox.jsx Standardized indentation to 4 spaces and added setActiveOperation handling for proper state cleanup
package-lock.json Removed "peer": true flags from multiple package entries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/TextForm.jsx
Comment thread src/components/TextForm.jsx
Comment thread src/components/TextForm.jsx
Comment thread src/components/TextForm.jsx
Comment thread src/components/TextForm.jsx
@vishruthmd

Copy link
Copy Markdown
Contributor Author

sure @palchhinparihar , do you want me to make the changes and open another new pull request?

@palchhinparihar

Copy link
Copy Markdown
Owner

Nah, just make your commits here! Don't need to make a new PR.

@vishruthmd

Copy link
Copy Markdown
Contributor Author

@palchhinparihar , sorry for the delay. Now the buttons in the dialog box have the cursor-pointer.

@palchhinparihar palchhinparihar added hacktoberfest Participating in Hacktoberfest hacktoberfest2025 Participating in Hacktoberfest 2025 hacktoberfest-accepted Accepted for the Hacktoberfest 2025 labels Oct 29, 2025
@palchhinparihar
palchhinparihar merged commit c4e6cf4 into palchhinparihar:main Oct 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest Participating in Hacktoberfest hacktoberfest2025 Participating in Hacktoberfest 2025 hacktoberfest-accepted Accepted for the Hacktoberfest 2025

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Clear Text leading to white screen of death

3 participants