Fixed inconsistent card hover colour across themes - #193
Merged
palchhinparihar merged 1 commit intoOct 30, 2025
Conversation
✅ Deploy Preview for wordwizard-texteditor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances theme customization by adding theme-specific card styling properties to all themes. The changes allow the SummaryCard component to use theme-specific colors for backgrounds, borders, and hover effects instead of hardcoded fallback values.
- Added
cardBg,cardBorder, andcardHoverproperties to all 14 themes in the themes data file - Updated SummaryCard component to accept and use the
currentThemeobject for dynamic styling - Passed the
currentThemeprop through the component chain (App → TextForm → SummaryCard)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/data/themes.js | Added card styling properties (cardBg, cardBorder, cardHover) to all theme objects |
| src/App.jsx | Passed currentTheme prop to TextForm component |
| src/components/TextForm.jsx | Forwarded currentTheme prop to SummaryCard component |
| src/components/SummaryCard.jsx | Updated to use theme-specific card styling with fallback defaults and removed unused idx parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
palchhinparihar
added
hacktoberfest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR updates the Summary Card hover colours to match each theme’s individual palette, improving visual consistency and aesthetics across all modes. Previously, all cards used the same purple hover colour regardless of theme.
Fixes #192
🔍 Type of Change
🧪 How Has This Been Tested?
Steps:
Result:
✅ Hover effects update dynamically per theme
✅ No visual regressions or styling conflicts
📸 Screenshots / Demo (if applicable)
🧠 Checklist
💬 Additional Notes
This update improves UI consistency and simplifies theme management by centralizing all colour logic in
themes.js.It also lays the groundwork for future theme additions - new themes will automatically apply correct hover colours without manual edits.