Skip to content

fix/sync-themes - #203

Merged
palchhinparihar merged 3 commits into
palchhinparihar:mainfrom
avaniparab:fix/sync-themes
Nov 15, 2025
Merged

fix/sync-themes#203
palchhinparihar merged 3 commits into
palchhinparihar:mainfrom
avaniparab:fix/sync-themes

Conversation

@avaniparab

Copy link
Copy Markdown
Contributor

📝 Description

This PR updates the FAQ, Terms of Use, Privacy Policy, and Contributors pages to dynamically adapt colors, backgrounds, and gradients based on the theme prop (light/dark).

  • Headings, paragraphs, cards, buttons, and CTA sections now change colors smoothly according to the theme.
  • Backgrounds and gradients of cards, CTA sections, and contributor items are synchronized with the selected theme.
  • Removed hardcoded colors that caused inconsistent display across themes (e.g., black background on Contributors page).

Fixes #201


🔍 Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧹 Code refactor (cleanup or optimization)
  • 🧪 Tests added/updated
  • 📝 Documentation update

🧪 How Has This Been Tested?

Steps:

  1. Run the application in light mode.
  2. Verify all headings, paragraphs, cards, buttons, and CTA sections display correct colors and gradients.
  3. Switch to dark mode.
  4. Confirm all elements update dynamically to the dark theme equivalents.
  5. Check responsiveness of contributor cards, FAQ dropdowns, and CTA hover effects.

📸 Screenshots / Demo (if applicable)

Screenshot 2025-11-05 at 10 40 57 PM Screenshot 2025-11-09 at 9 28 33 PM

🧠 Checklist

  • My code follows the project's coding style and conventions
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • I have updated related documentation (if applicable)
  • My changes generate no new warnings or errors
  • I have linked related issue numbers (if any)
  • All tests pass successfully

💬 Additional Notes

This update ensures a consistent and professional look across all pages for both light and dark themes. It also sets a foundation for future dynamic theme enhancements and gradient improvements.

@netlify

netlify Bot commented Nov 9, 2025

Copy link
Copy Markdown

Deploy Preview for wordwizard-texteditor ready!

Name Link
🔨 Latest commit 97210fb
🔍 Latest deploy log https://app.netlify.com/projects/wordwizard-texteditor/deploys/691866b42727ab0008d2dc81
😎 Deploy Preview https://deploy-preview-203--wordwizard-texteditor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@palchhinparihar

Copy link
Copy Markdown
Owner

@avaniparab, I can't able to merge your PR.

Error

@avaniparab avaniparab closed this Nov 10, 2025
@avaniparab avaniparab reopened this Nov 10, 2025
@palchhinparihar

Copy link
Copy Markdown
Owner

Still there is a problem

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds dynamic theme support (light/dark mode) to the FAQ, Terms of Use, Privacy Policy, and Contributors pages. The changes ensure all UI elements adapt their colors, backgrounds, and gradients based on the theme prop passed to each component.

Key changes:

  • All four components now accept and utilize a theme prop to conditionally apply light or dark mode styles
  • Removed hardcoded gradient backgrounds in favor of transparent backgrounds with theme-aware card styling
  • Updated text colors, borders, buttons, and CTA sections to respond dynamically to theme changes

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
src/App.jsx Passes theme prop to TermsOfUse and Contributors components (FAQ and PrivacyPolicy already had it)
src/components/TermsOfUse.jsx Adds theme prop and applies conditional styling to all elements including headings, cards, paragraphs, and buttons
src/components/PrivacyPolicy.jsx Adds theme prop and updates all UI elements with theme-aware colors and gradients
src/components/FAQ.jsx Adds theme prop, removes search functionality, and applies conditional theme-based styling throughout
src/components/Contributors.jsx Updates loading and content sections with theme-aware styling to replace hardcoded black background

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/Contributors.jsx
Comment thread src/components/Contributors.jsx
Comment thread src/components/PrivacyPolicy.jsx
Comment thread src/components/PrivacyPolicy.jsx
Comment thread src/components/PrivacyPolicy.jsx
Comment thread src/components/PrivacyPolicy.jsx
Comment thread src/components/PrivacyPolicy.jsx
Comment thread src/components/PrivacyPolicy.jsx
@palchhinparihar
palchhinparihar merged commit 6846674 into palchhinparihar:main Nov 15, 2025
6 checks passed
@avaniparab

Copy link
Copy Markdown
Contributor Author

hey @palchhinparihar, how was that blocked merge thing was removed??

@palchhinparihar

palchhinparihar commented Nov 15, 2025

Copy link
Copy Markdown
Owner

@avaniparab, a file was missing in the repo so yeah due to that the issue was occurring.

@avaniparab

Copy link
Copy Markdown
Contributor Author

@palchhinparihar, actual set up of codeQL?

@palchhinparihar

Copy link
Copy Markdown
Owner

yes yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistent Theme Application

3 participants