Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add query when mapping #42

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Feat/add query when mapping #42

merged 2 commits into from
Mar 24, 2025

Conversation

MaryKilewe
Copy link
Contributor

@MaryKilewe MaryKilewe commented Mar 24, 2025

Summary by Sourcery

Display the connection type only when the source system data is not loading.

Copy link
Contributor

sourcery-ai bot commented Mar 24, 2025

Reviewer's Guide by Sourcery

This pull request adds a query to prevent the application from crashing when the source system is loading. The query is added to the source system data connection type.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a query to prevent the application from crashing when the source system is loading.
  • Added a query to the source system data connection type.
src/pages/mapper/CsvAndApiMapper.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@MaryKilewe MaryKilewe merged commit b816a39 into master Mar 24, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MaryKilewe - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using optional chaining instead of !isSourceSystemLoading && sourceSystemData.conn_type.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -42,7 +42,7 @@ const CsvAndApiMapper = () => {
<Grid container spacing={3}>
<Grid item xs={12}>
<Stack direction="row" justifyContent="space-between" alignItems="baseline" sx={{ mb: { xs: -0.5, sm: 0.5 } }}>
<Typography color="text.info" variant="h4">{baselookup} Mapping for {sourceSystemData.conn_type}
<Typography color="text.info" variant="h4">{baselookup} Mapping for {!isSourceSystemLoading && sourceSystemData.conn_type}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Potential issue with using a boolean short-circuit rendering logic.

When isSourceSystemLoading is true, the expression will render false which may display an unwanted 'false' string. Consider using a ternary operator (e.g., isSourceSystemLoading ? '' : sourceSystemData.conn_type) to ensure a cleaner rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant