-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add query when mapping #42
Conversation
…ontend into feat/AddQueryWhenMapping
Reviewer's Guide by SourceryThis pull request adds a query to prevent the application from crashing when the source system is loading. The query is added to the source system data connection type. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MaryKilewe - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using optional chaining instead of
!isSourceSystemLoading && sourceSystemData.conn_type
.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -42,7 +42,7 @@ const CsvAndApiMapper = () => { | |||
<Grid container spacing={3}> | |||
<Grid item xs={12}> | |||
<Stack direction="row" justifyContent="space-between" alignItems="baseline" sx={{ mb: { xs: -0.5, sm: 0.5 } }}> | |||
<Typography color="text.info" variant="h4">{baselookup} Mapping for {sourceSystemData.conn_type} | |||
<Typography color="text.info" variant="h4">{baselookup} Mapping for {!isSourceSystemLoading && sourceSystemData.conn_type} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Potential issue with using a boolean short-circuit rendering logic.
When isSourceSystemLoading is true, the expression will render false which may display an unwanted 'false' string. Consider using a ternary operator (e.g., isSourceSystemLoading ? '' : sourceSystemData.conn_type) to ensure a cleaner rendering.
Summary by Sourcery
Display the connection type only when the source system data is not loading.