Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear issuesList if no issues found #46

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Conversation

MaryKilewe
Copy link
Contributor

@MaryKilewe MaryKilewe commented Mar 25, 2025

Summary by Sourcery

Resets the issues list when no issues are found during testing in the TestCsvMappings, TestMappings, and TestQueryMappings components. This ensures the issues table is cleared when a test run is successful.

Enhancements:

  • Updates the TestCsvMappings, TestMappings, and TestQueryMappings components to clear the issues list when no issues are found during testing.
  • Refactors the components to use a local state variable issuesList instead of testMappingsData?.data to manage and display issues, providing more control over the rendering of the issues table.

Copy link
Contributor

sourcery-ai bot commented Mar 25, 2025

Reviewer's Guide by Sourcery

This pull request ensures that the issues list is cleared when no issues are found after testing the mappings. This prevents the table from displaying stale data from previous tests. The changes involve initializing the issuesList state, setting it to null when no issues are found, and updating the table's conditional rendering to rely on the issuesList state.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
The issues list is now cleared when no issues are found during the test mapping process.
  • Initialized issuesList state variable to null.
  • Set issuesList to null when the testing response indicates no issues.
  • Updated the conditional rendering of the table to depend on the issuesList state.
src/pages/mapper/test-mappings/TestCsvMappings.js
src/pages/mapper/test-mappings/TestMappings.js
src/pages/mapper/test-mappings/TestQueryMappings.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@MaryKilewe MaryKilewe merged commit 6125d17 into master Mar 25, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MaryKilewe - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider creating a shared component or hook to avoid duplicating the issuesList state and logic across multiple files.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant