DEPR: Deprecate non-ISO date string formats in DatetimeIndex.loc #62991
Conversation
raghavendranath
changed the title
raghavendranath
force-pushed
the
depr-datetimeindex-loc-slice-dayfirst
branch
4 times, most recently
from
2619e36 to
42c889a
Compare
…d add test suppressions
raghavendranath
force-pushed
the
depr-datetimeindex-loc-slice-dayfirst
branch
from
415367c to
109e1c2
Compare
|
Hi @WillAyd @MarcoGorelli @mroeschke The PR is ready for review whenever you have time. Thanks |
natmokval
added
the
Indexing
| return result | ||
|
|
||
|
|
||
| def _is_iso_format_string(date_str: str) -> bool: |
There was a problem hiding this comment.
Credit to @stefmolin for the original idea, but I don't think we should try and roll our own regex here if we can avoid it.
I see the standard library provides date.fromisostring, although that is documented to not work with "Reduced Precision" dates:
https://docs.python.org/3/library/datetime.html
Even still I wonder if we can't use that first and only fallback when it fails
| @pytest.mark.parametrize("bins", [None, [0, 5]], ids=repr) | ||
| @pytest.mark.parametrize("isort", [True, False]) | ||
| @pytest.mark.parametrize("normalize, name", [(True, "proportion"), (False, "count")]) | ||
| @pytest.mark.filterwarnings( |
There was a problem hiding this comment.
Why does this test need to filter warnings? It seems unrelated to the change?
| with pytest.raises(TypeError, match=msg): | ||
| dti.get_loc(key) | ||
|
|
||
| @pytest.mark.filterwarnings( |
There was a problem hiding this comment.
Does this test still exhibit the expected behavior if you change the test to use ISO strings?
| tm.assert_series_equal(ts[[Period("2012-01-02", freq="D")]], exp) | ||
|
|
||
| @pytest.mark.arm_slow | ||
| @pytest.mark.filterwarnings( |
There was a problem hiding this comment.
You can change the test data here to use ISO strings, unless it explicitly tests non-ISO for a reason
3 participants
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Before:
After:
There's no way to know if "1/10/2024" is being parsed as MM/DD or DD/MM until you run it. This deprecation pushes users toward ISO format to avoid the confusion.