You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The conversation sidebar and tabs from #111/#112 work locally and are completely absent from the published demo.
PDChat renders the conversation UI only when given an IChatConversationService, and it was registered in only one of the two demo hosts — PanoramicData.Blazor.Web, which is what runs locally. GitHub Pages publishes PanoramicData.Blazor.WebAssembly/Client, which had none. So the demo everyone actually looks at was the one host without the service.
My miss: I verified against the local Web host throughout and never against the artefact the public demo is built from.
Registers the same trio in the WASM client, with a comment in both files saying they must match and why. A shared AddDemoServices() extension would remove the class of bug rather than this instance — noted on the issue.
The conversation sidebar and tabs worked locally and were completely
absent from the published demo.
PDChat renders the conversation UI only when it is given an
IChatConversationService, and the service was registered in only one of
the two demo hosts: PanoramicData.Blazor.Web, which is what runs
locally. GitHub Pages publishes PanoramicData.Blazor.WebAssembly/Client,
which had no registration - so the demo everyone actually looks at was
the one host without the service.
Verified throughout against the local Web host and never against the
artefact the public demo is built from, which is exactly how this got
missed.
Registers the same trio in the WASM client, and puts a comment in both
files saying they have to match and why. A shared AddDemoServices()
extension would remove the class of bug rather than this instance; noted
on the issue rather than done here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119.
The conversation sidebar and tabs from #111/#112 work locally and are completely absent from the published demo.
PDChatrenders the conversation UI only when given anIChatConversationService, and it was registered in only one of the two demo hosts —PanoramicData.Blazor.Web, which is what runs locally. GitHub Pages publishesPanoramicData.Blazor.WebAssembly/Client, which had none. So the demo everyone actually looks at was the one host without the service.My miss: I verified against the local Web host throughout and never against the artefact the public demo is built from.
Registers the same trio in the WASM client, with a comment in both files saying they must match and why. A shared
AddDemoServices()extension would remove the class of bug rather than this instance — noted on the issue.🤖 Generated with Claude Code