fix(slackbot): upgrade deduped mention events - #1071
Open
decofe wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack may deliver the same visible message as both
messageandapp_mention. When the emptymessagecallback arrives first, Chat SDK currently claims the dedupe key and drops the later actionable mention.Patch Chat SDK dedupe state to rank mentions above non-mentions, allowing one atomic upgrade while retaining duplicate suppression. The upgrade path is serialized; normal first deliveries retain the existing set-if-absent fast path.
Adds regression coverage for both observed callback orders and asserts exactly one append/execution with attachment content preserved.
Validation:
pnpm --filter slackbotv2 test -- chat-sdk-emulate.test.ts(175 pass, 1 skipped)pnpm --filter slackbotv2 check:typesPrompted by: @kuyziss