-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix error messages and functions #14044
Closed
Closed
+51
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Jan 29, 2025
@mattsse all good ? |
mattsse
reviewed
Feb 6, 2025
@@ -76,7 +76,7 @@ where | |||
|
|||
/// Extend the list of peers with new peers that are configured with each of the given | |||
/// [`PeerConfig`]s. | |||
pub async fn extend_peer_with_config( | |||
pub async fn extend_peers_with_config( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we undo this because I think this is breaking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattsse okey , done
thanks
failing ci |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crates/net/network/src/listener.rs
is non-fatal error - is a non-fatal error
crates/net/network/src/manager.rs
indented - intended x4
crates/net/network/src/test_utils/testnet.rs
extend_peer_with_config - extend_peers_with_config
crates/net/network/tests/it/multiplex.rs
An protocol - A protocol
crates/net/network/tests/it/txgossip.rs
penalised - penalized
crates/net/peers/src/node_record.rs
a ENR - an ENR
if you have any questions , i will be happy to help
thanks !