Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix error messages and functions #14044

Closed
wants to merge 12 commits into from

Conversation

XxAlex74xX
Copy link
Contributor

@XxAlex74xX XxAlex74xX commented Jan 28, 2025

crates/net/network/src/listener.rs
is non-fatal error - is a non-fatal error

crates/net/network/src/manager.rs
indented - intended x4

crates/net/network/src/test_utils/testnet.rs
extend_peer_with_config - extend_peers_with_config

crates/net/network/tests/it/multiplex.rs
An protocol - A protocol

crates/net/network/tests/it/txgossip.rs
penalised - penalized

crates/net/peers/src/node_record.rs
a ENR - an ENR

if you have any questions , i will be happy to help
thanks !

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mattsse mattsse added the C-docs An addition or correction to our documentation label Jan 29, 2025
@XxAlex74xX XxAlex74xX requested a review from mattsse February 5, 2025 20:35
@XxAlex74xX
Copy link
Contributor Author

@mattsse all good ?

@@ -76,7 +76,7 @@ where

/// Extend the list of peers with new peers that are configured with each of the given
/// [`PeerConfig`]s.
pub async fn extend_peer_with_config(
pub async fn extend_peers_with_config(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we undo this because I think this is breaking

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattsse okey , done
thanks

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@XxAlex74xX XxAlex74xX requested a review from mattsse February 8, 2025 09:29
@mattsse
Copy link
Collaborator

mattsse commented Feb 10, 2025

failing ci
cant push changes because opened from main

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@XxAlex74xX XxAlex74xX closed this Feb 11, 2025
@XxAlex74xX XxAlex74xX mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants