-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(root): reveal proofs separately from state updates #14077
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #14077 will not alter performanceComparing Summary
|
…k-proof-reveal-separate
This does not significantly improve the latency, because revealing proofs is already very fast. We can try applying both proofs and state updates out-of-order in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbundle sparse trie proof revealing from state updates, so that we can reveal proofs out-of-order and make the last reveal of the slowest proof as fast as possible. State updates for the sparse trie should still be applied in the order of sequence numbers, because updates can depend on each other.
This PR changes the
ProofSequencer
structure into theStateUpdateSequencer
, and reveals proofs as soon as they come, only sequencing the state updates that should be applied in order.I don't have a particularly good block on mainnet that will show the improvement, so here's just last 10 mainnet blocks. There's basically no difference, but in theory it should improve on situations when a slow proof is delaying not just all state updates, but also revealing other proofs.
newPayload
latency @ mainnewPayload
latency @ this branch