optimism: OpPayloadBuilder operating on the pooled tx type #14086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamdiallam
commented
Jan 29, 2025
hamdiallam
force-pushed
the
reth_optimism_transaction_pool
branch
from
ee34ada to
87358f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13901
Updated the pool type to use the OpPooledTransaction. This will let me add the conditional to the pool type and validate the conditional against chain state.
Introduced the
optimism-transaction-poolpackage to remove the circular dep between node <> payloadTODO:
best_transactionson the OpPayloadTransactions trait. Still trying to figure out where this is coming from but putting up a draft in case there's something obvious that i'm missing.