chore(sdk): Use EthApiBuilder instead of FnOnce trait
#14442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-debt
emhane
requested review from
mattsse,
Rjected,
onbjerg and
klkvr
as code owners
ye, the trait bounds in rpc builder are madness |
…nto emhane/ethapi-builder
emhane
force-pushed
the
emhane/ethapi-builder
branch
from
5d23de0 to
4fc1af5
Compare
|
@mattsse lemme know if this is what you want |
emhane
requested review from
joshieDo,
shekhirin,
fgimenez and
gakonst
as code owners
mattsse
reviewed
Feb 20, 2025
klkvr
reviewed
Feb 21, 2025
crates/ethereum/node/src/node.rs
Outdated
Comment on lines
134
to
143
| fn build( | ||
| self, | ||
| provider: N::Provider, | ||
| pool: N::Pool, | ||
| network: N::Network, | ||
| evm: N::Evm, | ||
| config: EthConfig, | ||
| executor: impl TaskSpawner + 'static, | ||
| cache: EthStateCache<BlockTy<N::Types>, ReceiptTy<N::Types>>, | ||
| ) -> Self::EthApi { |
There was a problem hiding this comment.
this could just take an instance of N I think?
There was a problem hiding this comment.
yeah I think we should add the context container type back here but now generic over N
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12509
EthApiBuilderCtxwhich is no longer needed since the entireEthApiis passed to pubs and filter API builders.