Add dedicated Optimism Storage impl #14654
Open
+87
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programskillforverification
requested review from
mattsse,
Rjected,
fgimenez and
gakonst
as code owners
mattsse
requested changes
Feb 25, 2025
crates/optimism/storage/src/chain.rs
Outdated
Comment on lines
11
to
13
| /// Trait that implements how block bodies are written to the storage. | ||
| #[auto_impl::auto_impl(&, Arc)] | ||
| pub(crate) trait BlockBodyWriter<Provider, Body: BlockBody> { |
There was a problem hiding this comment.
I don't think we need to duplicate those traits?
can we not import:
crates/optimism/storage/src/chain.rs
Outdated
| ) -> ProviderResult<Vec<<Self::Block as Block>::Body>> { | ||
| let chain_spec = provider.chain_spec(); | ||
|
|
||
| let mut withdrawals_cursor = provider.tx_ref().cursor_read::<tables::BlockWithdrawals>()?; |
There was a problem hiding this comment.
this we can also optimize and only apply the shanghai is active check
programskillforverification
force-pushed
the
add-optimism-impl
branch
2 times, most recently
from
13b4935 to
f6a0360
Compare
programskillforverification
requested review from
onbjerg,
DaniPopes,
rkrasiuk,
shekhirin,
rakita and
joshieDo
as code owners
programskillforverification
force-pushed
the
add-optimism-impl
branch
from
f6a0360 to
e50c32b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #14652