Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix redundant Ok wrapping in install_exex closure #14705

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xminds
Copy link

@0xminds 0xminds commented Feb 25, 2025

Removed the unnecessary Ok wrapping around my_exex(ctx) since my_exex(ctx) already returns an eyre::Result<()>.

This is important because install_exex expects a closure that returns eyre::Result<()>. Wrapping the result in Ok changes the type to Result<eyre::Result<()>, _>, which would cause a compilation error or a logical issue.

@0xminds 0xminds requested a review from onbjerg as a code owner February 25, 2025 17:25
@DaniPopes DaniPopes enabled auto-merge February 25, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants