Skip to content

Conversation

@radik878
Copy link
Contributor

  • Replace saturating_sub with checked_sub when computing last_pruned_block to preserve None on underflow (meaning “block 0 not finished yet”) per PruneCheckpoint contract.
  • Save checkpoint with block_number: last_pruned_block.map(|b| prune_mode_block.min(b)) instead of forcing Some(...), maintaining the correct semantics and aligning with other segments (e.g., receipts, transaction_lookup).
  • This prevents incorrectly marking pruning as finished up to block 0 and ensures consistent checkpoint behavior across segments.

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Sep 30, 2025
@github-actions github-actions bot added S-stale This issue/PR is stale and will close with no further activity and removed S-stale This issue/PR is stale and will close with no further activity labels Oct 22, 2025
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed here

@mattsse mattsse closed this Nov 18, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Reth Tracker Nov 18, 2025
@radik878 radik878 deleted the fix/pruning-receipts-by-logs-checked-sub-checkpoint branch December 6, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants