Skip to content

Windows now needs msbuild dep for generate-bindings #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Windows now needs msbuild dep for generate-bindings #591

wants to merge 6 commits into from
+1 −1

Conversation

@NuSkooler
Copy link
Contributor

Need the dep as it's referenced in build.rs now.

Superhepper
Superhepper reviewed Oct 28, 2025
View reviewed changes
Copy link
Collaborator

@Superhepper Superhepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was very unfortunate , but true.

I would really have liked if there would have been a possibility to configure the feature dependencies based on platform. But I guess Cargo does not really support that.

@Superhepper
Copy link
Collaborator

You need to sign the commit. That is why the DCO does not pass.

ionut-arm
ionut-arm approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that this works on non-Windows platforms is a bit weird to me since the dependency is only specified for Windows, but I'm not gonna argue. Guess cargo is smart enough to figure it out

@NuSkooler
Copy link
Contributor Author

You need to sign the commit. That is why the DCO does not pass.

Singing updated!

@NuSkooler NuSkooler mentioned this pull request Oct 30, 2025
Open
@NuSkooler
Copy link
Contributor Author

Apologies, recreated PR here: #592

@NuSkooler NuSkooler closed this Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Superhepper Superhepper Superhepper approved these changes

@ionut-arm ionut-arm ionut-arm approved these changes

@Firstyear Firstyear Awaiting requested review from Firstyear

@wiktor-k wiktor-k Awaiting requested review from wiktor-k

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NuSkooler @Superhepper @ionut-arm @byndid-bryanashby