Add warning for poor activities convergence #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@povik (For future reference, |
parallaxsw
reviewed
Nov 16, 2024
| pass, visitor.maxChange()); | ||
| pass++; | ||
| } | ||
| if (visitor.maxChange() > 0.20) { |
There was a problem hiding this comment.
This warns for nearly every power regression I have even though the activities indeed do converge. Consider a circuit with no feedback. When the activities propagate on the first pass they change by whatever the input activity is (with may be > .2). Since there is no feedback they are not re-queued and regs is empty. The activities are converged but it still warns about non-convergence. I think the true criteria for non-convergence is "pass == max_activity_passes_". All of the opensta regressions I have converge, so maybe the place to start is to make a test case and submit it as an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider having a warning like this.
I've found on some designs in OpenROAD-flow-scripts the propagated activities don't converge mostly due to bad features in the input netlist. Having a warning like this would help uncover these cases.
I've picked an arbitrary value of 0.20 for the max change threshold, and as for the mesage number I picked one above the existing Power.cc message. Not sure if
messages.txtis maintained by some automated tooling but I tried inserting the message manually.