fix: secret update hanging due to missing stdin input - #2
Merged
Conversation
When updating an existing secret, gcloud secrets versions add with --data-file=- was called without providing stdin input, causing it to hang indefinitely. Now uses Popen with communicate() to pass the API key via stdin, same as the create case.
…eneric parallel_enrich
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parallel-cli enrich deploy --system bigqueryhanging when updating an existing secretProblem
When the secret
parallel-api-keyalready exists, the code called_run_command()withgcloud secrets versions add --data-file=-, but--data-file=-expects input from stdin. Since_run_command()doesn't provide stdin input, gcloud hangs indefinitely waiting for the API key.Solution
Use
subprocess.Popenwithcommunicate(input=api_key)for the update case, same as the create case already does.Test plan
parallel-cli enrich deploy --system bigquery --project=<project> --api-key=<key>when secret already exists