Log why request-handler unregistration fails during teardown

src/client/services/rpc-client.ts

@@ -176,12 +176,19 @@ export class RpcClient implements IRpcMethodRegistrar {
   }
 
   async unregisterMethod(methodName: string): Promise<boolean> {
-    if (!this.jsonRpcServer.hasMethod(methodName)) return false;
+    if (!this.jsonRpcServer.hasMethod(methodName)) {
+      logger.warn(`Cannot unregister RPC method ${methodName}: not locally registered`);
+      return false;
+    }
     const mutex = this.registrationMutexMap.get(methodName);
     return mutex.runExclusive(async () => {
-      if (!this.jsonRpcServer.hasMethod(methodName)) return false;
+      if (!this.jsonRpcServer.hasMethod(methodName)) {
+        logger.warn(`Cannot unregister RPC method ${methodName}: not locally registered`);
+        return false;
+      }
       const successful = await this.jsonRpcClient.request(UNREGISTER_METHOD, [methodName]);
       if (successful) this.jsonRpcServer.removeMethod(methodName);
+      else logger.warn(`Remote failed to unregister RPC method ${methodName}`);
       return successful;
     });
   }

src/shared/services/network.service.ts

@@ -317,9 +317,14 @@ export async function registerRequestHandler(
   if (requestHandlerOptions?.timeoutMilliseconds !== undefined)
     setTimeoutMsForRequestType(requestType, requestHandlerOptions.timeoutMilliseconds);
   return async () => {
-    if (!jsonRpc) return false;
+    if (!jsonRpc) {
+      logger.warn(`Could not unregister request handler for "${requestType}": jsonRpc is not set`);
+      return false;
+    }
     removeTimeoutMsForRequestType(requestType);
-    return jsonRpc.unregisterMethod(requestType);
+    const unregistered = await jsonRpc.unregisterMethod(requestType);
+    if (!unregistered) logger.warn(`Failed to unregister request handler for "${requestType}"`);
+    return unregistered;
   };
 }