Upgrade to React 19, Tailwind 4, and new shadcn baseline#153
Conversation
Propagate changes from paranext-core upgrade-shadcn branch: - Update package.json deps (React 19, TW4, @tailwindcss/postcss, @dreamsicle.io/stylelint-config-tailwindcss, tw-animate-css, shadcn@4.3.0, @fontsource-variable/ibm-plex-sans, lucide-react@1.8, eslint-plugin-react-hooks@5) - Slim tailwind.config.ts (TW4 moves theme/colors/etc into CSS) - postcss.config.ts uses @tailwindcss/postcss - .stylelintrc.js uses @Dreamsicle config and ignores new TW4 at-rules - src/tailwind.css rewritten for TW4: imports tailwindcss with prefix(tw), tw-animate-css, shadcn/tailwind.css, fontsource font; @theme inline, @custom-variant dark, oklch theme variables (light/dark/paratext-light/ paratext-dark) - web-view-resolve-webpack-plugin.ts: bind resolver.join to resolver Co-Authored-By: Claude Code <noreply@anthropic.com>
irahopkinson
left a comment
There was a problem hiding this comment.
One thing to check.
@irahopkinson reviewed 7 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on tjcouch-sil).
package-lock.json line 0 at r1 (raw file):
BTW the first commit looks like it changed this file correctly but the second commit seems to be reverting some of those changes. Is that what we want? My guess is you didn't have the changes in core when you made this change here, e.g. you might not have been on your PR #2207 branch.
- Rename CSS variable `--success` → `--success-foreground` (and the corresponding `--color-success` → `--color-success-foreground` in `@theme inline`) to align with shadcn's `*-foreground` naming. - Add `--warning` and `--warning-foreground` (amber-400/amber-950 in light themes, amber-900/amber-50 in dark themes) plus their `--color-warning` / `--color-warning-foreground` entries in `@theme inline`. Pulled from https://ui.shadcn.com/docs/theming#adding-new-tokens. - Add a CUSTOM "Theme variable policy" disclaimer at the top of the file reminding extension authors to prefer existing theme variables and to get UX approval before introducing new semantic colors.
b391455 to
9017bbc
Compare
irahopkinson
left a comment
There was a problem hiding this comment.
@irahopkinson reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved.
Propagate changes from paranext-core upgrade-shadcn branch:
This change is