Skip to content

Upgrade to React 19, Tailwind 4, and new shadcn baseline#153

Merged
tjcouch-sil merged 5 commits into
mainfrom
upgrade-shadcn
May 12, 2026
Merged

Upgrade to React 19, Tailwind 4, and new shadcn baseline#153
tjcouch-sil merged 5 commits into
mainfrom
upgrade-shadcn

Conversation

@tjcouch-sil

@tjcouch-sil tjcouch-sil commented May 5, 2026

Copy link
Copy Markdown
Member

Propagate changes from paranext-core upgrade-shadcn branch:

  • Update package.json deps (React 19, TW4, @tailwindcss/postcss, @dreamsicle.io/stylelint-config-tailwindcss, tw-animate-css, shadcn@4.3.0, @fontsource-variable/ibm-plex-sans, lucide-react@1.8, eslint-plugin-react-hooks@5)
  • Slim tailwind.config.ts (TW4 moves theme/colors/etc into CSS)
  • postcss.config.ts uses @tailwindcss/postcss
  • .stylelintrc.js uses @Dreamsicle config and ignores new TW4 at-rules
  • src/tailwind.css rewritten for TW4: imports tailwindcss with prefix(tw), tw-animate-css, shadcn/tailwind.css, fontsource font; @theme inline, @custom-variant dark, oklch theme variables (light/dark/paratext-light/ paratext-dark)
  • web-view-resolve-webpack-plugin.ts: bind resolver.join to resolver

This change is Reviewable

Propagate changes from paranext-core upgrade-shadcn branch:
- Update package.json deps (React 19, TW4, @tailwindcss/postcss,
  @dreamsicle.io/stylelint-config-tailwindcss, tw-animate-css,
  shadcn@4.3.0, @fontsource-variable/ibm-plex-sans, lucide-react@1.8,
  eslint-plugin-react-hooks@5)
- Slim tailwind.config.ts (TW4 moves theme/colors/etc into CSS)
- postcss.config.ts uses @tailwindcss/postcss
- .stylelintrc.js uses @Dreamsicle config and ignores new TW4 at-rules
- src/tailwind.css rewritten for TW4: imports tailwindcss with prefix(tw),
  tw-animate-css, shadcn/tailwind.css, fontsource font; @theme inline,
  @custom-variant dark, oklch theme variables (light/dark/paratext-light/
  paratext-dark)
- web-view-resolve-webpack-plugin.ts: bind resolver.join to resolver

Co-Authored-By: Claude Code <noreply@anthropic.com>

@irahopkinson irahopkinson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to check.

@irahopkinson reviewed 7 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on tjcouch-sil).


package-lock.json line 0 at r1 (raw file):
BTW the first commit looks like it changed this file correctly but the second commit seems to be reverting some of those changes. Is that what we want? My guess is you didn't have the changes in core when you made this change here, e.g. you might not have been on your PR #2207 branch.

- Rename CSS variable `--success` → `--success-foreground` (and the
  corresponding `--color-success` → `--color-success-foreground` in
  `@theme inline`) to align with shadcn's `*-foreground` naming.
- Add `--warning` and `--warning-foreground` (amber-400/amber-950 in
  light themes, amber-900/amber-50 in dark themes) plus their
  `--color-warning` / `--color-warning-foreground` entries in
  `@theme inline`. Pulled from
  https://ui.shadcn.com/docs/theming#adding-new-tokens.
- Add a CUSTOM "Theme variable policy" disclaimer at the top of the
  file reminding extension authors to prefer existing theme variables
  and to get UX approval before introducing new semantic colors.

@irahopkinson irahopkinson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@irahopkinson reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved.

@tjcouch-sil tjcouch-sil merged commit 5f44a9d into main May 12, 2026
5 checks passed
@tjcouch-sil tjcouch-sil deleted the upgrade-shadcn branch May 12, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants