Apply the latest extension template updates#61
Merged
Conversation
@typescript-eslint/* ^6 → ^8 - Fixes minimatch ReDoS vulnerabilities copy-webpack-plugin ^12 → ^14 - Fixes serialize-javascript RCE vulnerability eslint-config-erb removed - Source of the peer dep conflicts; replaced by direct configs eslint-config-airbnb-base removed - Redundant — eslint-config-airbnb already depends on it eslint-config-airbnb added - Previously pulled in by erb eslint-config-prettier added - Previously pulled in by erb eslint-plugin-prettier added - Previously pulled in by erb @stylistic/eslint-plugin-ts ^2.13.0 added - Provides lines-between-class-members rule with exceptAfterOverload support, which was removed from @typescript-eslint v8 ESLint behavioral parity: - All rules erb explicitly set are preserved. - lines-between-class-members now uses @stylistic/ts/lines-between-class-members to preserve the original exceptAfterOverload: true option. tsconfig.lint.json change: allowJs: true only affects the lint-specific tsconfig (not builds), and is the official replacement for the removed createDefaultProgram. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
… into update-from-templates-20260309
54a4639 Fix all npm audit vulnerabilities by upgrading dependencies (#136) git-subtree-dir: src/create-process-test git-subtree-split: 54a4639dc086cf5e48ed707b03c7b024062f0d67
54a4639 Fix all npm audit vulnerabilities by upgrading dependencies (#136) git-subtree-dir: src/theme-selector git-subtree-split: 54a4639dc086cf5e48ed707b03c7b024062f0d67
…rom-templates-20260309
54a4639 Fix all npm audit vulnerabilities by upgrading dependencies (#136) git-subtree-dir: src/verse-ref-view git-subtree-split: 54a4639dc086cf5e48ed707b03c7b024062f0d67
…rom-templates-20260309
…rom-templates-20260309
git-subtree-dir: src/website-viewer git-subtree-split: 54a4639dc086cf5e48ed707b03c7b024062f0d67
There was a problem hiding this comment.
Pull request overview
Applies the latest Platform.Bible extension template updates across the repo and brings the website-viewer extension back in sync with the template (including build/lint/release automation).
Changes:
- Updated lint/typecheck tooling (ESLint config + TS lint tsconfigs) and refreshed devDependencies across workspaces.
- Updated
website-viewerbuild pipeline (webpack/webview handling), Tailwind theme variables, and extension manifest metadata. - Added template automation to
website-viewer(bump-versions script + GitHub workflows/actions/assets).
Reviewed changes
Copilot reviewed 46 out of 51 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.lint.json | Enables JS parsing in the root lint TSConfig to support updated ESLint setup. |
| src/website-viewer/webpack/webpack.util.ts | Comment/doc consistency updates for WebView naming/matching utilities. |
| src/website-viewer/webpack/webpack.config.web-view.ts | Updates WebView webpack config comments/docs to match template guidance. |
| src/website-viewer/webpack/webpack.config.main.ts | Aligns main bundling target/output behavior with template module-restriction approach. |
| src/website-viewer/webpack/webpack.config.base.ts | Updates shared webpack defaults (externals/module rules) to template baseline. |
| src/website-viewer/webpack/web-view-resolve-webpack-plugin.ts | Minor comment updates for WebView resolution flow. |
| src/website-viewer/webpack.config.ts | Aligns build sequencing comment terminology with template (“WebViews”). |
| src/website-viewer/tsconfig.lint.json | Enables JS parsing in lint TSConfig to match updated ESLint project usage. |
| src/website-viewer/tailwind.config.ts | Adds typography theme variable mapping consistent with template styling. |
| src/website-viewer/src/tailwind.css | Updates theme variables + shared base layer styles to match template/platform styling. |
| src/website-viewer/package.json | Refreshes tooling deps/scripts (ESLint/Stylelint/Webpack/etc.) and adds bump-versions script. |
| src/website-viewer/manifest.json | Aligns manifest fields with template conventions (camelCase name, publisher, themes). |
| src/website-viewer/lib/git.util.ts | Adds template git utility helper for scripts in the extension repo. |
| src/website-viewer/lib/bump-versions.ts | Adds template bump-versions automation script for release/version workflows. |
| src/website-viewer/contributions/themes.json | Adds themes contribution placeholder referenced by manifest. |
| src/website-viewer/assets/displayData.json | Points display description to localized markdown path per template. |
| src/website-viewer/README.md | Updates README/template guidance and publishing instructions. |
| src/website-viewer/LICENSE | Updates license header content (currently template placeholder). |
| src/website-viewer/.vscode/settings.json | Updates VS Code ESLint validation + file associations for template dev UX. |
| src/website-viewer/.vscode/launch.json | Updates debug launch args for newer Chromium remote-origin requirements. |
| src/website-viewer/.stylelintrc.js | Aligns Stylelint rules with template (Prettier compatibility + Tailwind at-rules). |
| src/website-viewer/.github/workflows/publish.yml | Adds template publish workflow for packaging and draft GitHub releases. |
| src/website-viewer/.github/workflows/lint.yml | Adds template lint workflow for CI formatting/lint checks. |
| src/website-viewer/.github/workflows/codeql.yml | Adds template CodeQL scanning workflow. |
| src/website-viewer/.github/workflows/bump-versions.yml | Adds template bump-versions workflow for version automation. |
| src/website-viewer/.github/assets/release-body.md | Adds template release-body scaffold used by publish workflow. |
| src/website-viewer/.github/actions/bump-versions-action/action.yml | Adds composite action wrapper to run bump-versions in workflows. |
| src/website-viewer/.github/CODEOWNERS | Adds ownership metadata for the extension folder. |
| src/website-viewer/.gitattributes | Adds template git attributes (EOL + binary patterns) for the extension. |
| src/website-viewer/.eslintrc.js | Replaces ERB config with Airbnb-based ruleset and template overrides/settings. |
| src/verse-ref-view/tsconfig.lint.json | Enables JS parsing in lint TSConfig per updated ESLint project setup. |
| src/verse-ref-view/package.json | Refreshes lint/tooling dependencies to match template baseline. |
| src/verse-ref-view/lib/git.util.ts | Aligns execCommand return shape with template (stdout/stderr strings). |
| src/verse-ref-view/.eslintrc.js | Replaces ERB config with Airbnb-based ruleset and template overrides/settings. |
| src/theme-selector/tsconfig.lint.json | Enables JS parsing in lint TSConfig per updated ESLint project setup. |
| src/theme-selector/package.json | Refreshes lint/tooling dependencies and Volta node version alignment. |
| src/theme-selector/lib/git.util.ts | Aligns execCommand return shape with template (stdout/stderr strings). |
| src/theme-selector/.eslintrc.js | Replaces ERB config with Airbnb-based ruleset and template overrides/settings. |
| src/create-process-test/tsconfig.lint.json | Enables JS parsing in lint TSConfig per updated ESLint project setup. |
| src/create-process-test/package.json | Refreshes lint/tooling dependencies and Volta node version alignment. |
| src/create-process-test/lib/git.util.ts | Aligns execCommand return shape with template (stdout/stderr strings). |
| src/create-process-test/.eslintrc.js | Replaces ERB config with Airbnb-based ruleset and template overrides/settings. |
| package.json | Updates repo-wide tooling deps (ESLint stack, webpack, node types) and Volta node version. |
| lib/update-from-templates.ts | Tightens error type-guarding to avoid calling methods on non-Error values. |
| lib/git.util.ts | Aligns execCommand return shape with template and removes unused catch binding. |
| .eslintrc.cjs | Replaces ERB config with Airbnb-based ruleset and template overrides/settings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
tjcouch-sil
reviewed
Mar 9, 2026
tjcouch-sil
left a comment
tjcouch-sil
left a comment
Member
There was a problem hiding this comment.
Looked at everything but package-lock.json as I didn't have time tonight. Thanks!! I know this took a lot of time 💀
@tjcouch-sil reviewed 47 files and all commit messages, and made 1 comment.
Reviewable status: 47 of 51 files reviewed, all discussions resolved (waiting on Sebastian-ubs).
tjcouch-sil
approved these changes
Mar 10, 2026
tjcouch-sil
left a comment
tjcouch-sil
left a comment
Member
There was a problem hiding this comment.
@tjcouch-sil reviewed 4 files and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Sebastian-ubs).
lyonsil
commented
Mar 10, 2026
lyonsil
left a comment
lyonsil
left a comment
Member
Author
There was a problem hiding this comment.
Thanks - it looks like this requires approval from @Sebastian-ubs , too as I'm touching the website-viewer code.
@lyonsil made 1 comment.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required recreating the website-viewer extension because it wasn't attached to the template
This change is