Update httpparty & rspec #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with instruction on how to subscribe an email address to a mailing list.
|
@adelawalla @jpearson-sfdc any chance you can look into this? would love to see it merged |
|
Looks like this has been fixed in the latest PRs (specifically #56). Let me know if I missed anything or if there is an issue. Sorry for the late reply. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I needed to be able to use this gem with a more modern version of
httppartysimilar to what was done in #47.After updating, the test suite failed, so I updated
rspecas part of the process of resolving the error and handling a deprecation warning.There are some slight styling changes -- preferring
:over=>in hashes and some rubocop complaints -- and the diffs a little noisy because my editor removed whitespace padding in the edited files.And finally, adds a small blurb about how to subscribe an email address to a mailing list.