Send PeerId via UMP #10145
Open
Send PeerId via UMP #10145
+201
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
force-pushed
the
send-approved-peer-ump-signal
branch
2 times, most recently
from
f19389c to
97bebcf
Compare
serban300
force-pushed
the
send-approved-peer-ump-signal
branch
from
97bebcf to
730dfc3
Compare
serban300
force-pushed
the
send-approved-peer-ump-signal
branch
from
730dfc3 to
239752a
Compare
sandreim
reviewed
Oct 30, 2025
| /// This method expects to receive a `Vec` of at most 64 bytes. Otherwise, it panics. | ||
| pub fn unchecked_new_approved_peer_id(bytes: Vec<u8>) -> ApprovedPeerId { | ||
| ApprovedPeerId::try_from(bytes) | ||
| .expect("unchecked_new_approved_peer_id() should receive a sequence of at most 64 bytes") |
There was a problem hiding this comment.
Not really nice this panics. Maybe Option better ?
| relay_chain_state, | ||
| relay_parent_descendants, | ||
| collator_peer_id: None, | ||
| collator_peer_id: Some(collator_peer_id), |
There was a problem hiding this comment.
I think this is the only place where we should convert using unchecked_new_approved_peer_id, and keep using the client network primitive PeerId across the node.
| CumulusDigestItem::find_core_info(&frame_system::Pallet::<T>::digest()) | ||
| { | ||
| ump_signals.push( | ||
| UMPSignal::SelectCore(core_info.selector, core_info.claim_queue_offset).encode(), |
There was a problem hiding this comment.
We should double check before merging if UMPSignal::ApprovedPeer is supported by current RC runtimes.
| // Take the pending UMP signals. | ||
| let mut ump_signals = PendingUpwardSignals::<T>::take(); | ||
| // Append the core selector signal. | ||
| if let Some(core_info) = |
There was a problem hiding this comment.
Looks a bit inconsistent now that you added PendingUpwardSignals, why not put UMPSignal::SelectCore there as well ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7749