security: enforce HTTPS with HSTS via Helmet - #953
Open
Sarthak816 wants to merge 1 commit into
Open
Conversation
Explicitly configure Strict Transport Security through helmet's strictTransportSecurity option, replacing the default HSTS settings (180 days) with a one-year maxAge including subdomains and the preload flag, so browsers refuse plain-HTTP connections to the API and MITM downgrade attacks are blocked. Closes parthbuilds-community#950
github-actions
Bot
added
refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #950
Summary
Explicitly configures HTTP Strict Transport Security (HSTS) in the Express server so browsers refuse to connect to the API over plain HTTP, blocking MITM downgrade attacks.
Changes
server/index.js: replaced the defaultapp.use(helmet())HSTS settings (180-day max-age) with an explicitstrictTransportSecurityconfig:maxAge: 31536000(1 year),includeSubDomains: true, andpreload: true.Resulting header
Verified against a live server:
Notes
preload: trueopts the domain into the HSTS preload list; the domain must also be submitted to https://hstspreload.org before preload takes effect.Validation