Skip to content

Conversation

@hugomontero
Copy link
Contributor

@hugomontero hugomontero commented Oct 14, 2025

Description

  • Add OS selector at the beginning of the setup process
  • Change setup process to use defined workflows depending on the selected OS

How to Test

  • Pull down the branch: git pull && git checkout feature/sc-136003/make-os-can-be-selected-by-the-user-into-tachyon
  • For every OS type do:
    • Setup the device: npm start -- tachyon setup
    • Setup the device by using an existing configuration file: npm start -- tachyon setup --load_config /path/config/file
    • Setup the device and store a new config file: npm start -- tachyon setup --save_config /path/new/config/file
    • Setup the device and use any allowed flag like --version or --skip_flashing_os

Tests:

  • Ubuntu 20.04
  • Ubuntu 24.04
  • Android 14

Outcome

  • Every single setup should work
  • Some steps should be skipped since is in the config file, should be a message indicating if the step was skipped. In case there is no workflow field in the config it will take ubuntu20 by default
  • On storing a new config file: every field should match with old config files except by a new field workflow
  • When using flags these should still being accepted and used by the process.

Related Issues / Discussions

Story details: https://app.shortcut.com/particle/story/136003/make-os-can-be-selected-by-the-user-into-tachyon-setup

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@hugomontero hugomontero force-pushed the feature/sc-136003/make-os-can-be-selected-by-the-user-into-tachyon branch from bf6f884 to b2a3728 Compare October 14, 2025 21:49
@hugomontero hugomontero force-pushed the feature/sc-136003/make-os-can-be-selected-by-the-user-into-tachyon branch from b2a3728 to 0eb720d Compare October 14, 2025 21:52
@hugomontero hugomontero requested a review from monkbroc October 15, 2025 14:59
@hugomontero hugomontero marked this pull request as ready for review October 15, 2025 15:41
@monkbroc monkbroc force-pushed the feature/sc-136003/make-os-can-be-selected-by-the-user-into-tachyon branch from 10969f9 to f50d861 Compare October 16, 2025 16:58
Copy link
Member

@monkbroc monkbroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I'll own tweaking the text based on Nick's feedback then merging.

@monkbroc monkbroc requested a review from mrlambchop October 24, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants