-
Notifications
You must be signed in to change notification settings - Fork 93
Feature/sc 136003/make os can be selected by the user into tachyon #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hugomontero
wants to merge
11
commits into
master
Choose a base branch
from
feature/sc-136003/make-os-can-be-selected-by-the-user-into-tachyon
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/sc 136003/make os can be selected by the user into tachyon #874
hugomontero
wants to merge
11
commits into
master
from
feature/sc-136003/make-os-can-be-selected-by-the-user-into-tachyon
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf6f884 to
b2a3728
Compare
b2a3728 to
0eb720d
Compare
10969f9 to
f50d861
Compare
hugomontero
commented
Oct 16, 2025
monkbroc
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I'll own tweaking the text based on Nick's feedback then merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to Test
git pull && git checkout feature/sc-136003/make-os-can-be-selected-by-the-user-into-tachyonnpm start -- tachyon setupnpm start -- tachyon setup --load_config /path/config/filenpm start -- tachyon setup --save_config /path/new/config/file--versionor--skip_flashing_osTests:
Outcome
ubuntu20by defaultworkflowRelated Issues / Discussions
Story details: https://app.shortcut.com/particle/story/136003/make-os-can-be-selected-by-the-user-into-tachyon-setup
Completeness