Skip to content

Error message if index column not found#104

Merged
Handy-caT merged 1 commit intopathscale:mainfrom
YohDeadfall:err-msg-instead-unwrap
Aug 9, 2025
Merged

Error message if index column not found#104
Handy-caT merged 1 commit intopathscale:mainfrom
YohDeadfall:err-msg-instead-unwrap

Conversation

@YohDeadfall
Copy link
Copy Markdown

Unfortunately, the crate uses proc_macro and unwrap in code. It causes really unhelpful messages issues by the compiler as it gives zero context where None was instead of an expected Option::Some.

Ideally, the crate should use proc_macro_error2 or any other fine crate for that. It requires a lot of efforts, so let it be just panic with something meaningful.

@Handy-caT Handy-caT merged commit 55a02d1 into pathscale:main Aug 9, 2025
0 of 3 checks passed
@Handy-caT
Copy link
Copy Markdown
Collaborator

@yoh, instead of proc_macro_error2 I'm using syn::Error's for proper error handling in codegen. #106

@YohDeadfall YohDeadfall deleted the err-msg-instead-unwrap branch August 11, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants