Skip to content

Conversation

@thatblindgeye
Copy link
Contributor

Closes #768

@patternfly-build
Copy link

patternfly-build commented Nov 25, 2025

@thatblindgeye thatblindgeye marked this pull request as ready for review November 25, 2025 19:35
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also want to check to see how the additional items work in a resizable toolbar/different breakpoints, etc. if we are not completely offloading toolbar creation to the end user.


### Drawer with search actions

The conversation history drawer supports additional customization through `searchActionStart` and `searchActionEnd` props, which allow you to add controls before and after the search input field. These props are useful for adding filtering, sorting, or other search-related functionality.
Copy link
Contributor

@edonehoo edonehoo Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The conversation history drawer supports additional customization through `searchActionStart` and `searchActionEnd` props, which allow you to add controls before and after the search input field. These props are useful for adding filtering, sorting, or other search-related functionality.
You can customize the search experience within the conversation history drawer via the `searchActionStart` and `searchActionEnd` props, which provide additional search controls before and after the input field. These props are useful for adding filtering, sorting, or other search-related functionality.

a small tweak - otherwise I like what you have!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is done

Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fabulous to me 👍

Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine by me - you probably just want to make sure the yarn.lock file gets dropped. Up to you and Nicole if you want to allow the semi-custom toolbar approach as well as the custom one!

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why the package-lock.json and yarn.lock files are updated here?
Do you want to double check those updates are both necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Allow adding a Sort Button Next to the Search input field in ChatbotConversationHistoryNav

5 participants