Skip to content

chore(chart theme): convert to typescript #11891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Mash707
Copy link
Contributor

@Mash707 Mash707 commented Jun 26, 2025

Towards #11719

The following examples are converted:

  • Green
  • Multi-color (ordered)
  • Multi color (unordered)
  • Custom color scale
  • Custom stroke color
  • Custom theme

@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 26, 2025

@Mash707 Mash707 mentioned this pull request Jun 26, 2025
18 tasks
y?: number;
}

export const CustomeThemeCustomTheme: React.FunctionComponent = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const CustomeThemeCustomTheme: React.FunctionComponent = () => {
export const ChartThemeCustomTheme: React.FunctionComponent = () => {

@Mash707 Mash707 requested a review from thatblindgeye July 12, 2025 07:37
y?: number;
}

export const CustomThemeCustomTheme: React.FunctionComponent = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also just needs to be updated to match the file name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops , I wrote CustomTheme two times😅.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice you wrote it twice! 😆

@Mash707 Mash707 requested a review from thatblindgeye July 14, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants