chore(chart theme): convert to typescript #11891
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11891.surge.sh A11y report: https://patternfly-react-pr-11891-a11y.surge.sh |
18 tasks
thatblindgeye
requested changes
Jul 11, 2025
| y?: number; | ||
| } | ||
|
|
||
| export const CustomeThemeCustomTheme: React.FunctionComponent = () => { |
There was a problem hiding this comment.
Suggested change
| export const CustomeThemeCustomTheme: React.FunctionComponent = () => { | |
| export const ChartThemeCustomTheme: React.FunctionComponent = () => { |
thatblindgeye
requested changes
Jul 14, 2025
| y?: number; | ||
| } | ||
|
|
||
| export const CustomThemeCustomTheme: React.FunctionComponent = () => { |
There was a problem hiding this comment.
This also just needs to be updated to match the file name
There was a problem hiding this comment.
Oops , I wrote CustomTheme two times😅.
There was a problem hiding this comment.
So nice you wrote it twice! 😆
thatblindgeye
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #11719
The following examples are converted: