-
Notifications
You must be signed in to change notification settings - Fork 370
chore(chart theme): convert to typescript #11891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(chart theme): convert to typescript #11891
Conversation
Preview: https://patternfly-react-pr-11891.surge.sh A11y report: https://patternfly-react-pr-11891-a11y.surge.sh |
y?: number; | ||
} | ||
|
||
export const CustomeThemeCustomTheme: React.FunctionComponent = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const CustomeThemeCustomTheme: React.FunctionComponent = () => { | |
export const ChartThemeCustomTheme: React.FunctionComponent = () => { |
y?: number; | ||
} | ||
|
||
export const CustomThemeCustomTheme: React.FunctionComponent = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also just needs to be updated to match the file name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops , I wrote CustomTheme
two times😅.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So nice you wrote it twice! 😆
Towards #11719
The following examples are converted: