Adds CardDescription component #12105
Conversation
|
Preview: https://pf-react-pr-12105.surge.sh A11y report: https://pf-react-pr-12105-a11y.surge.sh |
dlabaj
changed the title
dlabaj
force-pushed
the
cardDescription
branch
from
104a371 to
d741b63
Compare
| ### Basic cards | ||
|
|
||
| Basic cards typically have a `<CardTitle>`, `<CardBody>` and `<CardFooter>`. You may omit these components as needed, but it is recommended to at least include a `<CardBody>` to provide details about the card item. | ||
| Basic cards typically have a `<CardTitle>`, `<CardSubtitle>`, `<CardBody>` and `<CardFooter>`. You may omit these components as needed, but it is recommended to at least include a `<CardBody>` to provide details about the card item. |
There was a problem hiding this comment.
Would we want to say that cards will typically have a subtitle, or should the subtitles be just somsthing that can be added but aren't usually there?
There was a problem hiding this comment.
To match the core structure, CardTitle needs a subtitle prop which passes the content and puts the cardSubtitle at a sibling level to the CardTitle's internal cardTitleText div. The current implementation is putting the cardSubtitle as a child of cardTitleText.
I think I would prefer making the subtitle prop represent only the ReactNode content and conditionally rendering the cardSubtitle div in CardTitle based on the prop, but I'd also be fine with keeping CardSubtitle as a component.
4 participants
Adds tests to ensure the CardDescription component renders correctly with PatternFly Core styles, handles className, and spreads extra props to the root element.