-
Notifications
You must be signed in to change notification settings - Fork 13
fix: Creates an overview page #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rebeccaalpert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy-editing stuff/links look great to me. Just one comment/question about the page format since it looks different from ChatBot's overview, but I don't want to block you.
| title: Catalog view overview | ||
| section: extensions | ||
| subsection: Catalog view | ||
| source: react |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah it looks like the framework wants the demo heading to be an h3. I think the source just specifies the tab label, which doesn't change much in this instance since there aren't subtabs on this page
Gonna fiddle!
rebeccaalpert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
🎉 This PR is included in version 6.3.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |

Part of patternfly/patternfly-org#4678