replace ddtrace with datadog for new ruby version [v1.1.0] #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the ddtrace gem dependency with the datadog gem to support Ruby 3.4.6 compatibility, as ddtrace is not compatible with Ruby versions >= 3.4.
- Updated gem dependency from
ddtrace >= 1.13.0todatadog >= 2.0.0 - Updated gem summary to reflect the dependency change
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mukteshd
changed the title
The gemspec was requiring datadog_notifier.rb which loads the datadog gem, but this gem isn't available during bundle install phase. This caused LoadError in CI when installing dependencies. Solution: Only require datadog_notifier/version.rb in gemspec since it has no external dependencies.
amoludage
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Clickup Link - https://app.clickup.com/t/2323726/DIST-18283
Description
As part of updating rails app to use ruby 3.4.6, we needed to change ddrace gem with datadog since ddtrace was only compatible with ruby < 3.4
This change requires to replace dependency in datadog notifier gem from ddtrace to datadog
Types of changes
Checklist