Skip to content

Hitting enter on a non-empty set of elements will select the first one #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Hitting enter on a non-empty set of elements will select the first one #365

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c707ae
When hitting enter with a nonempty list of elements, it will select t…
josh-byster Aug 24, 2018
3bec9b6
Fixed conflicts on merge
josh-byster Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions src/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,21 +615,23 @@ var EasyAutocomplete = (function (scope) {

function bindKeydown() {
$field
.on('keydown', function (evt) {
evt = evt || window.event;
var keyCode = evt.keyCode;
if (keyCode === 38) {
suppressKeypress = true;
return false;
}
})
.keydown(function (event) {

if (event.keyCode === 13 && selectedElement > -1) {

//enter

$field.val(config.get('getValue')(elementsList[selectedElement]));
.on("keydown", function(evt) {
evt = evt || window.event;
var keyCode = evt.keyCode;
if (keyCode === 38) {
suppressKeypress = true;
return false;
}
})
.keydown(function(event) {
// if the enter key is pressed
if (event.keyCode === 13) {
if(selectedElement == -1 && elementsList.length > 0){
// nothing is selected, so just autofill the first selection
selectedElement = 0;
}
$field.val(config.get("getValue")(elementsList[selectedElement]));


config.get('list').onKeyEnterEvent();
config.get('list').onChooseEvent();
Expand Down